fix(files): Fix unresponsive file click to download - #42566
Merged
Conversation
Member
Author
|
/backport 5e7ba12 to stable28 |
juliusknorr
approved these changes
Jan 3, 2024
Member
Author
|
Pushed simpler alternative fixups which moves the |
skjnldsv
approved these changes
Jan 5, 2024
Member
Code make sense :) |
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Pytal
force-pushed
the
fix/files-download-default-action
branch
from
January 6, 2024 00:49
9dce79a to
5267d62
Compare
Pytal
added
4. to release
Pytal
enabled auto-merge
January 6, 2024 01:05
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With #42457 a regression is introduced due to the
event.preventDefault()which prevents link activationTo preserve ctrl-click functionality and fix the non-triggering download we need to set the download action as default so it executes
Checklist