Skip to content

fix styling of development-notice - #42700

Merged
szaimen merged 2 commits into
masterfrom
enh/42642/fix-development-notice-styling
Jan 11, 2024
Merged

fix styling of development-notice#42700
szaimen merged 2 commits into
masterfrom
enh/42642/fix-development-notice-styling

Conversation

@szaimen

@szaimen szaimen commented Jan 11, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Close #42642

Before

Aufzeichnung.2024-01-11.114319.mp4

After

Aufzeichnung.2024-01-11.114018.mp4
For my own testing 
docker run -it --rm ^
--name nextcloud-easy-test ^
-p 8443:443 ^
--volume="nextcloud_easy_test_npm_cache_volume:/var/www/.npm" ^
-e SERVER_BRANCH=enh/42642/fix-development-notice-styling ^
-e COMPILE_SERVER=1 ^
-e VIEWER_BRANCH=master ^
ghcr.io/szaimen/nextcloud-easy-test:latest

@szaimen szaimen added this to the Nextcloud 29 milestone Jan 11, 2024
@szaimen
szaimen force-pushed the enh/42642/fix-development-notice-styling branch from d3e0896 to 7e5f51e Compare January 11, 2024 10:35
@szaimen
szaimen marked this pull request as ready for review January 11, 2024 10:43
@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 11, 2024
@szaimen szaimen added the design Design, UI, UX, etc. label Jan 11, 2024
@susnux

susnux commented Jan 11, 2024

Copy link
Copy Markdown
Contributor

should we fix the icon? Probably missing filter: var(--primary-invert-if-dark) (or similar)

@szaimen

szaimen commented Jan 11, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

should we fix the icon? Probably missing filter: var(--primary-invert-if-dark) (or similar)

Í fear this does not work here as the icon is no item but only a css class:
image

emoral435
emoral435 approved these changes Jan 11, 2024
View reviewed changes

@emoral435 emoral435 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@szaimen
szaimen force-pushed the enh/42642/fix-development-notice-styling branch from 7e5f51e to 5004718 Compare January 11, 2024 14:26
@szaimen
szaimen enabled auto-merge January 11, 2024 14:27
@szaimen

szaimen commented Jan 11, 2024

Copy link
Copy Markdown
Contributor Author

/compile

szaimen and others added 2 commits January 11, 2024 10:19
@szaimen @emoral435
fix styling of development-notice
cf17267 
Signed-off-by: Simon L <szaimen@e.mail.de>
@nextcloud-command @emoral435
chore(assets): Recompile assets
a6863ce 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@emoral435
emoral435 force-pushed the enh/42642/fix-development-notice-styling branch from 0ce5c15 to a6863ce Compare January 11, 2024 16:19
@szaimen

szaimen commented Jan 11, 2024

Copy link
Copy Markdown
Contributor Author

/backport cf17267 to stable28

@szaimen
szaimen disabled auto-merge January 11, 2024 17:22
@szaimen
szaimen merged commit 07749e6 into master Jan 11, 2024
@szaimen
szaimen deleted the enh/42642/fix-development-notice-styling branch January 11, 2024 17:22
@backportbot-nextcloud backportbot-nextcloud Bot mentioned this pull request Jan 11, 2024
Merged
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux approved these changes
@juliusknorr juliusknorr Awaiting requested review from juliusknorr
@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter
@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan
@Pytal Pytal Awaiting requested review from Pytal
@ShGKme ShGKme Awaiting requested review from ShGKme
+1 more reviewer
@emoral435 emoral435 emoral435 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

3. to review Waiting for reviews accessibility design Design, UI, UX, etc.

Projects

None yet

Milestone

Nextcloud 29

Development

Successfully merging this pull request may close these issues.

[BITV]: hover contrasts on links are not ok

4 participants

@szaimen @susnux @emoral435 @nextcloud-command