Skip to content

Replace inaccessible disabled option of NcCheckboxRadioSwitch with NcNoteCard - #43015

Merged
JuliaKirschenheuter merged 2 commits into
masterfrom
fix/42941-Replace_samtically_incorrect_elements_on_Artificial_Intelligence_setting_page
Jan 23, 2024
Merged

Replace inaccessible disabled option of NcCheckboxRadioSwitch with NcNoteCard#43015
JuliaKirschenheuter merged 2 commits into
masterfrom
fix/42941-Replace_samtically_incorrect_elements_on_Artificial_Intelligence_setting_page

Conversation

@JuliaKirschenheuter

@JuliaKirschenheuter JuliaKirschenheuter commented Jan 22, 2024 •
edited by susnux
Loading

Copy link
Copy Markdown
Contributor

Replace inaccessible disabled option of NcCheckboxRadioSwitch with NcNoteCard

Summary

🖼️ Screenshots

🏚️ Before 🏡 After
image Screenshot from 2024-01-22 11-33-24

Checklist

@JuliaKirschenheuter JuliaKirschenheuter added the 3. to review Waiting for reviews label Jan 22, 2024
@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Jan 22, 2024
szaimen
szaimen reviewed Jan 22, 2024
View reviewed changes
Comment thread apps/settings/src/components/AdminAI.vue Outdated
@JuliaKirschenheuter
JuliaKirschenheuter force-pushed the fix/42941-Replace_samtically_incorrect_elements_on_Artificial_Intelligence_setting_page branch from f9fe94c to 419f4f7 Compare January 22, 2024 10:34
szaimen
szaimen approved these changes Jan 22, 2024
View reviewed changes

@szaimen szaimen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@JuliaKirschenheuter

JuliaKirschenheuter commented Jan 22, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

/compile /

@emoral435

emoral435 commented Jan 22, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

/backport aa8f76d to stable28

JuliaKirschenheuter and others added 2 commits January 22, 2024 13:31
@JuliaKirschenheuter @emoral435
fix(files): replace inaccessible disabled option of NcCheckboxRadioSw…
aa8f76d 
…itch with NcNoteCard

Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
@nextcloud-command @emoral435
chore(assets): Recompile assets
60df95f 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@emoral435
emoral435 force-pushed the fix/42941-Replace_samtically_incorrect_elements_on_Artificial_Intelligence_setting_page branch from 5f0a7aa to 60df95f Compare January 22, 2024 19:31
@susnux susnux added this to the Nextcloud 29 milestone Jan 22, 2024
@JuliaKirschenheuter
JuliaKirschenheuter merged commit 4bf4cee into master Jan 23, 2024
@JuliaKirschenheuter
JuliaKirschenheuter deleted the fix/42941-Replace_samtically_incorrect_elements_on_Artificial_Intelligence_setting_page branch January 23, 2024 08:02
@backportbot backportbot Bot mentioned this pull request Jan 23, 2024
Merged
1 task
@emoral435 emoral435 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 23, 2024
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShGKme ShGKme ShGKme approved these changes
@szaimen szaimen szaimen approved these changes
@susnux susnux Awaiting requested review from susnux
@Pytal Pytal Awaiting requested review from Pytal
+1 more reviewer
@emoral435 emoral435 emoral435 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@JuliaKirschenheuter JuliaKirschenheuter

Labels

4. to release Ready to be released and/or waiting for tests to finish accessibility bug

Projects

None yet

Milestone

Nextcloud 29

Development

Successfully merging this pull request may close these issues.

6 participants

@JuliaKirschenheuter @emoral435 @ShGKme @szaimen @susnux @nextcloud-command