Move modal outside of the Version component. - #43084
Merged
Merged
Conversation
artonge
force-pushed
the
artonge/feat/version_list
branch
from
January 24, 2024 14:48
ece3cc2 to
a25295c
Compare
artonge
added
3. to review
artonge
force-pushed
the
artonge/feat/version_list
branch
2 times, most recently
from
January 24, 2024 14:59
a28123e to
e0d1deb
Compare
artonge
requested review from
a team,
nfebe and
sorbaugh
and removed request for
a team
January 24, 2024 15:14
JuliaKirschenheuter
approved these changes
Jan 24, 2024
JuliaKirschenheuter
left a comment
JuliaKirschenheuter
left a comment
Contributor
There was a problem hiding this comment.
Thank you Louis!
emoral435
approved these changes
Jan 24, 2024
ShGKme
requested changes
Jan 24, 2024
artonge
force-pushed
the
artonge/feat/version_list
branch
2 times, most recently
from
January 25, 2024 10:19
bb4a8ce to
89a8c87
Compare
ShGKme
approved these changes
Jan 25, 2024
artonge
force-pushed
the
artonge/feat/version_list
branch
from
January 25, 2024 13:32
89a8c87 to
cc4f8e5
Compare
Contributor
|
cypress is related and needs fixing |
artonge
force-pushed
the
artonge/feat/version_list
branch
2 times, most recently
from
January 25, 2024 15:53
280f4db to
0a10c78
Compare
artonge
enabled auto-merge
January 25, 2024 17:25
This is for accessibility, to have the NcListItem (<li>) as a direct child of the <ul> Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge
force-pushed
the
artonge/feat/version_list
branch
from
January 26, 2024 15:38
0a10c78 to
ea732fa
Compare
Contributor
|
/backport to stable28 |
2 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is for accessibility, to have the
NcListItem(<li>) as a direct child of the<ul>Diff is big, but is mostly white spaces, moved code, and a rewrite in ts of
versions.js.