feat(db): Make dirty query logging available in production - #43185
Merged
Conversation
ChristophWurst
added
enhancement
3. to review
ChristophWurst
requested review from
Altahrim,
AndyScherzinger,
juliusknorr,
nickvergessen and
sorbaugh
January 29, 2024 10:46
nickvergessen
approved these changes
Jan 29, 2024
AndyScherzinger
approved these changes
Jan 29, 2024
AndyScherzinger
left a comment
AndyScherzinger
left a comment
Member
There was a problem hiding this comment.
formal approval, not a technical one ;)
juliusknorr
approved these changes
Jan 30, 2024
Member
|
Time to fixup and merge |
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
force-pushed
the
feat/db/dirty-queries-production
branch
from
January 30, 2024 09:31
3aeb53e to
911ab39
Compare
ChristophWurst
added
4. to release
ChristophWurst
enabled auto-merge
January 30, 2024 09:31
Altahrim
approved these changes
Jan 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes #42345 usable in production environments.
How to test
master: nothing related to dirty queries
here: #43109 logged with level 3
Checklist