Use AccountPlusIcon in broadcrombs - #43433
Merged
Merged
Conversation
szaimen
force-pushed
the
enh/40202/use-correct-icon
branch
2 times, most recently
from
February 7, 2024 13:15
6e97ea8 to
e91fdad
Compare
szaimen
marked this pull request as ready for review
February 7, 2024 13:25
jancborchardt
requested changes
Feb 7, 2024
jancborchardt
left a comment
Member
There was a problem hiding this comment.
Nice @szaimen! Only one remark: The opacity is there to give a slight indication about the shared state, but maybe we can do it with the same colors as in the file list instead? (color-main-text and color-primary)
szaimen
force-pushed
the
enh/40202/use-correct-icon
branch
2 times, most recently
from
February 7, 2024 14:08
162fb15 to
bac1b13
Compare
Contributor
Author
Should be fixed now :) |
jancborchardt
approved these changes
Feb 7, 2024
jancborchardt
left a comment
Member
There was a problem hiding this comment.
Did not test the code but seems good
nimishavijay
approved these changes
Feb 7, 2024
This comment was marked as resolved.
This comment was marked as resolved.
szaimen
enabled auto-merge
February 7, 2024 19:08
nextcloud-command
force-pushed
the
enh/40202/use-correct-icon
branch
from
February 7, 2024 19:14
bac1b13 to
7981bf8
Compare
This comment was marked as resolved.
This comment was marked as resolved.
skjnldsv
approved these changes
Feb 8, 2024
Member
this does NOT ignore conflicts |
Contributor
Author
Yeah, figured that out already 😅😥 |
szaimen
force-pushed
the
enh/40202/use-correct-icon
branch
from
February 8, 2024 09:42
7981bf8 to
0dbbdea
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Simon L <szaimen@e.mail.de>
skjnldsv
force-pushed
the
enh/40202/use-correct-icon
branch
from
February 8, 2024 10:01
0dbbdea to
a183a23
Compare
Member
|
/backport to stable28 |
2 tasks
artonge
pushed a commit
that referenced
this pull request
Feb 8, 2024
Use AccountPlusIcon in broadcrombs
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #40202
Close #42502
Supercedes #42502
For my own testing