chore(index.php): Use strict_types and Server::get in index.php - #43460
Merged
Conversation
come-nc
marked this pull request as ready for review
February 8, 2024 15:21
come-nc
added
3. to review
come-nc
force-pushed
the
fix/strict-typing-in-index-php
branch
from
February 8, 2024 15:22
6caf081 to
b3277f4
Compare
come-nc
requested review from
a team,
ArtificialOwl,
icewind1991 and
nfebe
and removed request for
a team
February 8, 2024 15:22
emoral435
approved these changes
Feb 8, 2024
Altahrim
approved these changes
Feb 9, 2024
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
force-pushed
the
fix/strict-typing-in-index-php
branch
from
February 12, 2024 08:22
b3277f4 to
15fb15b
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Small followup for #43454
index.phpwas already pretty clean so small PR.Checklist