fix: changed text alignment and icon logic - #43876
Merged
Merged
Conversation
emoral435
force-pushed
the
fix/breadcrumbs/fix-misaligned-text
branch
from
February 27, 2024 16:53
abd9f86 to
fbce6af
Compare
emoral435
marked this pull request as ready for review
February 27, 2024 17:15
susnux
reviewed
Feb 27, 2024
susnux
reviewed
Feb 27, 2024
emoral435
force-pushed
the
fix/breadcrumbs/fix-misaligned-text
branch
from
February 28, 2024 01:38
fbce6af to
28da105
Compare
susnux
reviewed
Feb 28, 2024
emoral435
force-pushed
the
fix/breadcrumbs/fix-misaligned-text
branch
from
February 28, 2024 15:25
28da105 to
fd12b13
Compare
skjnldsv
approved these changes
Feb 28, 2024
Member
|
/backport to stable28 |
emoral435
enabled auto-merge
February 28, 2024 17:27
Member
|
conflicts 🙈 |
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
emoral435
force-pushed
the
fix/breadcrumbs/fix-misaligned-text
branch
from
February 29, 2024 13:03
fd12b13 to
2b4ec59
Compare
Contributor
Author
|
Fixed 🐘 |
This comment was marked as resolved.
This comment was marked as resolved.
2 tasks
Merged
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unrelated, but while testing this, it seems that the uploading section of this component seems to block the view of the breadcrumbs even when you are not uploading something. May have to do with our upload stores queue not updating correctly? Will test later!
Screenshots of the new change
Checklist