Do not create a new version for empty files - #43896
Merged
Merged
Conversation
artonge
added
bug
2. developing
artonge
marked this pull request as ready for review
February 28, 2024 15:07
artonge
force-pushed
the
artonge/fix/version_creation_of_empty_files
branch
from
February 29, 2024 11:42
5343261 to
0b1f71a
Compare
Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge
force-pushed
the
artonge/fix/version_creation_of_empty_files
branch
from
February 29, 2024 20:32
0b1f71a to
66fbb7b
Compare
artonge
added
3. to review
skjnldsv
approved these changes
Mar 1, 2024
Altahrim
approved these changes
Mar 1, 2024
Collaborator
Author
|
/backport to stable28 |
Collaborator
Author
|
/backport to stable27 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #43262
I knew it was a special case at the time I wrote the code, not sure why I handled it like so though 🤔.