fix: Fetch custom app store url without internet connection - #43972
Merged
Conversation
juliusknorr
requested review from
a team,
come-nc,
icewind1991 and
nfebe
and removed request for
a team
March 4, 2024 08:46
icewind1991
approved these changes
Mar 4, 2024
come-nc
approved these changes
Mar 4, 2024
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
force-pushed
the
fix/fetch-custom-appstore
branch
from
March 4, 2024 11:47
45d18d0 to
e13fb46
Compare
Member
Author
|
/backport to stable28 |
Member
Author
|
/backport to stable27 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should still fetch custom app store urls even when having has_internet_connection configured to false as the app store might be in the internal network.