Split live photo listener to extract trashbin specific code into its own listener - #44069
Merged
Conversation
![github-advanced-security[bot]](https://cdn.github.com/in/57789?s=60&v=4){kind=small}
artonge
force-pushed
the
artonge/fix/split_live_photo_listener
branch
from
March 8, 2024 11:24
c9f3267 to
3640bd7
Compare
artonge
force-pushed
the
artonge/fix/split_live_photo_listener
branch
2 times, most recently
from
March 11, 2024 14:08
4146c2a to
68ebdfb
Compare
artonge
force-pushed
the
artonge/fix/split_live_photo_listener
branch
from
March 11, 2024 17:09
68ebdfb to
398727b
Compare
Merged
artonge
force-pushed
the
artonge/fix/split_live_photo_listener
branch
3 times, most recently
from
March 12, 2024 11:34
2852e39 to
db6269c
Compare
artonge
marked this pull request as ready for review
March 12, 2024 12:32
artonge
force-pushed
the
artonge/fix/split_live_photo_listener
branch
3 times, most recently
from
March 12, 2024 13:14
66fdc90 to
53fb9d4
Compare
artonge
force-pushed
the
artonge/fix/split_live_photo_listener
branch
4 times, most recently
from
March 12, 2024 17:52
0710141 to
eee43f9
Compare
artonge
added
3. to review
artonge
changed the title
artonge
force-pushed
the
artonge/fix/split_live_photo_listener
branch
3 times, most recently
from
March 13, 2024 10:09
ce472e6 to
3da98b0
Compare
susnux
approved these changes
Mar 13, 2024
susnux
requested review from
a team and
icewind1991
and removed request for
a team
March 13, 2024 11:53
Merged
come-nc
reviewed
Mar 14, 2024
skjnldsv
approved these changes
Mar 14, 2024
artonge
force-pushed
the
artonge/fix/split_live_photo_listener
branch
from
March 14, 2024 09:55
3da98b0 to
491a5e9
Compare
This prevent random slowdown during tests, making them more reliable, and faster. Signed-off-by: Louis Chemineau <louis@chmn.me>
This avoid elements to be hided by a fixed top bar. Especially useful for the file list. Signed-off-by: Louis Chemineau <louis@chmn.me>
Fix #43299 Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge
force-pushed
the
artonge/fix/split_live_photo_listener
branch
from
March 14, 2024 10:07
491a5e9 to
01fe326
Compare
Member
|
/backport to stable28 |
Merged
2 tasks
Member
Looks like the backport got missed :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #43299
Done
TODO