Expose subscription calendars - #44752
Merged
Merged
Conversation
kesselb
force-pushed
the
feat/noid/expose-subscription-calendars
branch
3 times, most recently
from
April 16, 2024 20:33
b60f373 to
8acafd1
Compare
kesselb
marked this pull request as ready for review
April 16, 2024 21:23
kesselb
requested review from
ChristophWurst,
miaulalala and
tcitworld
as code owners
April 16, 2024 21:23
Contributor
Author
|
Patch the calendar app for easier testing: |
Contributor
Author
|
Example calendar for testing: https://www.feiertage-deutschland.de/kalender-download/ics/feiertage-deutschland.ics |
GVodyanov
self-requested a review
April 18, 2024 15:24
kesselb
force-pushed
the
feat/noid/expose-subscription-calendars
branch
from
April 22, 2024 14:55
8acafd1 to
3ba89ea
Compare
Member
|
Can this expose the subscription source as well? Would be handy for nextcloud/calendar#5168 too |
kesselb
force-pushed
the
feat/noid/expose-subscription-calendars
branch
from
April 23, 2024 15:18
3ba89ea to
acc19d4
Compare
Contributor
Author
Added getSource to CachedSubscriptionImpl |
miaulalala
approved these changes
May 7, 2024
kesselb
force-pushed
the
feat/noid/expose-subscription-calendars
branch
from
May 7, 2024 12:53
17bcc92 to
230e707
Compare
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
force-pushed
the
feat/noid/expose-subscription-calendars
branch
from
May 7, 2024 14:03
230e707 to
e210043
Compare
Contributor
Author
|
/backport to stable29 |
Contributor
Author
|
/backport to stable28 |
2 tasks
This was referenced May 7, 2024
Closed
Closed
Contributor
Author
|
/backport to stable27 |
2 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make calendar subscriptions available via php api.
TODO
PR for Calendar to increase the event limitReplaced by CalDAV fix search with limit and time range #45222Test cases
Checklist