Support multiple scopes in DAV search - #44858
Merged
artonge merged 1 commit intoApr 22, 2024
Merged
Conversation
This was referenced Apr 16, 2024
artonge
force-pushed
the
artonge/feat/support_multiple_scope_in_dav_search
branch
3 times, most recently
from
April 16, 2024 14:18
e168062 to
3cba742
Compare
artonge
force-pushed
the
artonge/feat/support_multiple_scope_in_dav_search
branch
from
April 16, 2024 15:03
3cba742 to
91e6cdd
Compare
icewind1991
requested changes
Apr 16, 2024
icewind1991
left a comment
Member
There was a problem hiding this comment.
If there is only a single folder, doing the search on the folder is more efficient as it can filter down the storages it searches in
artonge
force-pushed
the
artonge/feat/support_multiple_scope_in_dav_search
branch
from
April 16, 2024 16:56
e3a9de0 to
817ac06
Compare
artonge
force-pushed
the
artonge/feat/support_multiple_scope_in_dav_search
branch
from
April 17, 2024 07:49
0e6b256 to
8709037
Compare
artonge
force-pushed
the
artonge/feat/support_multiple_scope_in_dav_search
branch
2 times, most recently
from
April 17, 2024 09:47
3c42472 to
784e43b
Compare
| * @param Query $search | ||
| * @return SearchResult[] | ||
| */ | ||
| public function search(Query $search): array { |
Check notice
Code scanning / Psalm
ParamNameMismatch
Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge
force-pushed
the
artonge/feat/support_multiple_scope_in_dav_search
branch
from
April 17, 2024 10:33
784e43b to
ac0acfb
Compare
emoral435
reviewed
Apr 17, 2024
emoral435
approved these changes
Apr 17, 2024
emoral435
left a comment
Contributor
There was a problem hiding this comment.
This LGTM. In terms of optimization, I am generally unknowledgeable here, but the code logic makes sense :)
come-nc
reviewed
Apr 22, 2024
icewind1991
approved these changes
Apr 22, 2024
Collaborator
Author
|
/backport to stable29 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of making the search on the targeted folders, the current approach does it on the user's root folder, with some extra conditions applied on the path.
This allows the following scope in WebDAV
SEARCHrequests:This can be tested with the following PR in Photos: nextcloud/photos#2426
With that PR, the SQL request will look like that: