Update pdf icon - #45218
Merged
Merged
Conversation
marcoambrosini
requested review from
a team,
jancborchardt,
nimishavijay and
szaimen
May 7, 2024 11:07
susnux
reviewed
May 7, 2024
jancborchardt
previously requested changes
May 7, 2024
jancborchardt
left a comment
jancborchardt
left a comment
Member
There was a problem hiding this comment.
As discussed with @marcoambrosini, we should keep the previous coloring of the icon because it looks less intense and much better together with the default folder color.
marcoambrosini
force-pushed
the
update-pdf-icon
branch
from
May 13, 2024 08:52
96531e2 to
55347a5
Compare
marcoambrosini
enabled auto-merge
May 13, 2024 08:56
ShGKme
approved these changes
May 13, 2024
susnux
approved these changes
May 13, 2024
Signed-off-by: Marco Ambrosini <marcoambrosini@proton.me>
marcoambrosini
force-pushed
the
update-pdf-icon
branch
from
May 13, 2024 09:36
55347a5 to
edc809a
Compare
Member
|
/backport to stable29 |
jancborchardt
approved these changes
May 14, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.