feat(templates): checkbox field type - #47290
Merged
Merged
Conversation
elzody
added
enhancement
2. developing
elzody
force-pushed
the
feat/checkbox-template-field-type
branch
from
August 16, 2024 20:43
d9995e1 to
494bf61
Compare
This was referenced Aug 16, 2024
elzody
changed the title
elzody
force-pushed
the
feat/checkbox-template-field-type
branch
from
August 20, 2024 17:25
e226009 to
cff52d9
Compare
elzody
marked this pull request as ready for review
August 20, 2024 17:25
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
juliusknorr
reviewed
Aug 21, 2024
juliusknorr
reviewed
Aug 21, 2024
elzody
force-pushed
the
feat/checkbox-template-field-type
branch
from
August 26, 2024 14:03
cff52d9 to
8a7e847
Compare
juliusknorr
reviewed
Aug 26, 2024
juliusknorr
reviewed
Aug 26, 2024
juliusknorr
reviewed
Aug 26, 2024
juliusknorr
reviewed
Aug 26, 2024
juliusknorr
left a comment
juliusknorr
left a comment
Member
There was a problem hiding this comment.
Generally fine, just some small comments
jancborchardt
approved these changes
Aug 26, 2024
jancborchardt
left a comment
jancborchardt
left a comment
Member
There was a problem hiding this comment.
Looks nice design-wise! :)
elzody
force-pushed
the
feat/checkbox-template-field-type
branch
from
August 27, 2024 14:46
16f9565 to
c0c6e6a
Compare
kesselb
approved these changes
Aug 27, 2024
Contributor
Author
|
/backport to stable30 |
elzody
enabled auto-merge
August 27, 2024 15:53
susnux
reviewed
Aug 27, 2024
| </template> | ||
|
|
||
| <script lang="ts"> | ||
| <script> |
Contributor
Author
There was a problem hiding this comment.
Wasn't using TypeScript in this file, but if it makes it more consistent with the rest of the files I can leave it as TS.
susnux
reviewed
Aug 27, 2024
elzody
disabled auto-merge
August 27, 2024 16:44
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
elzody
force-pushed
the
feat/checkbox-template-field-type
branch
from
August 27, 2024 18:44
9ba3f16 to
a82a542
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Merged
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR will introduce a checkbox type when filling templates.
Part of nextcloud/richdocuments#3917
2024-08-26.13-01-49.mp4
Note
Tests are implemented from the richdocuments side: nextcloud/richdocuments#3919
Checklist