update docs for Folder.get and call for Folder.nodeExists - #48455
Merged
Conversation
kesselb
requested review from
artonge,
come-nc,
icewind1991 and
provokateurin
September 30, 2024 12:09
kesselb
marked this pull request as ready for review
September 30, 2024 12:09
provokateurin
approved these changes
Sep 30, 2024
come-nc
approved these changes
Sep 30, 2024
kesselb
force-pushed
the
update-phpdoc-for-folder-get
branch
2 times, most recently
from
September 30, 2024 16:25
0d66eff to
1287d3a
Compare
artonge
approved these changes
Sep 30, 2024
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
force-pushed
the
update-phpdoc-for-folder-get
branch
from
September 30, 2024 17:00
1287d3a to
fbaa4cc
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The main implemention already documents it, now the interface does as well. The other
OCP/Files/Folderimplementations (Folder, LazyFolder) wrap IRootFolder and therefore will throw as well.server/lib/private/Files/Node/Root.php
Lines 174 to 192 in be87dec
TODO
Checklist