refactor(Storage): Align all Storage constructors - #48614
Merged
Conversation
come-nc
approved these changes
Oct 8, 2024
provokateurin
force-pushed
the
refactor/storage/constructors
branch
from
October 14, 2024 05:11
ccf70fc to
61b97dd
Compare
provokateurin
requested review from
a team,
ArtificialOwl,
artonge and
icewind1991
and removed request for
a team
October 14, 2024 05:11
artonge
reviewed
Oct 14, 2024
provokateurin
force-pushed
the
refactor/storage/constructors
branch
from
October 22, 2024 09:15
61b97dd to
09e3855
Compare
artonge
approved these changes
Oct 22, 2024
provokateurin
enabled auto-merge
October 22, 2024 11:04
Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurin
force-pushed
the
refactor/storage/constructors
branch
from
October 23, 2024 11:24
09e3855 to
0de4843
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds strong types, removes wrong doc blocks and uses the same parameter name everywhere.
Checklist