feat(systemtags): add setting to block non admin to create system tags by Altahrim · Pull Request #49514 · nextcloud/server

Altahrim · 2024-11-27T08:31:17Z

Summary

Allows admins to restrict tag creation to admins only

Switch with:

occ conf:app:set systemtags --type boolean only_admins_can_create --value 0|1

TODO

Add frontend switch in system tags settings
Change display on tag selection for users who can't create tags
Block color changing too

Checklist

Code is properly formatted
Sign-off message is added to all commits
Tests (unit, integration, api and/or acceptance) are included
Screenshots before/after for front-end changes
Documentation (manuals or wiki) has been updated or is not required
Backports requested where applicable (ex: critical bugfixes)

nfebe · 2025-01-06T19:37:10Z

Frontend switch

Enabled	Disabled

Error view

Error	NA
	NA

provokateurin

Only minor things, LGTM

nfebe · 2025-01-18T22:11:26Z

/compile

nfebe · 2025-01-21T09:34:34Z

/compile

artonge

Nitpicking on the naming. But not blocking :)

Altahrim · 2025-01-21T13:32:18Z

/compile

nfebe · 2025-01-22T19:02:06Z

/compile

Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>

Signed-off-by: nfebe <fenn25.fn@gmail.com>

Added support for the `only_admin_can_create` flag in system tags. The UI now hides the option to create tags when this flag is enabled, ensuring compliance with admin settings. Signed-off-by: nfebe <fenn25.fn@gmail.com>

nfebe · 2025-01-22T19:14:07Z

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

skjnldsv · 2025-03-05T08:35:20Z

 		$this->initialStateService->provideInitialState('profileEnabledByDefault', $this->isProfileEnabledByDefault($this->config));

+		// Basic settings
+		$this->initialStateService->provideInitialState('restrictSystemTagsCreationToAdmin', $this->appConfig->getValueString('systemtags', 'restrict_creation_to_admin', 'true'));


The value is NOT stored as a boolean in the backend, but as an integer @Altahrim

skjnldsv · 2025-03-05T08:41:02Z

+		if (loadState('settings', 'restrictSystemTagsCreationToAdmin', '0') === '1' && getCurrentUser()?.isAdmin !== true) {
+			return false
+		}


@nfebe why are we preventing the entire bulk tagging action if creation is disabled?
It does NOT mean we cannot apply tags....

Will fix in followup

Altahrim added enhancement 2. developing Work in progress feature: tags labels Nov 27, 2024

Altahrim added this to the Nextcloud 31 milestone Nov 27, 2024

Altahrim self-assigned this Nov 27, 2024

Altahrim force-pushed the feat/restrict-tag-creation branch 4 times, most recently from d561ba1 to 7ed6833 Compare November 28, 2024 12:36

Altahrim force-pushed the feat/restrict-tag-creation branch from 7ed6833 to c158e06 Compare December 9, 2024 09:23

nfebe force-pushed the feat/restrict-tag-creation branch 3 times, most recently from 8c7bd05 to 06bb2f1 Compare December 20, 2024 12:04

nfebe force-pushed the feat/restrict-tag-creation branch 2 times, most recently from e27715d to d8d3c7e Compare January 2, 2025 14:55

nfebe force-pushed the feat/restrict-tag-creation branch 3 times, most recently from 5b049ce to 5cf90d5 Compare January 13, 2025 14:12

nfebe marked this pull request as ready for review January 13, 2025 14:15

nfebe force-pushed the feat/restrict-tag-creation branch from 5cf90d5 to f7e6dc9 Compare January 13, 2025 14:51

nfebe requested review from Pytal, artonge, come-nc, provokateurin and skjnldsv January 13, 2025 14:54

sorbaugh approved these changes Jan 13, 2025

View reviewed changes

provokateurin approved these changes Jan 13, 2025

View reviewed changes

Altahrim removed the 2. developing Work in progress label Jan 14, 2025

Altahrim force-pushed the feat/restrict-tag-creation branch from f7e6dc9 to 001ec5a Compare January 14, 2025 08:52

Altahrim force-pushed the feat/restrict-tag-creation branch 2 times, most recently from 69f8d5e to 76ad5e2 Compare January 17, 2025 14:43

nfebe force-pushed the feat/restrict-tag-creation branch from 76ad5e2 to 2df437f Compare January 18, 2025 22:11

Altahrim force-pushed the feat/restrict-tag-creation branch from 2fcd63f to 4840a06 Compare January 20, 2025 11:59

Altahrim enabled auto-merge January 20, 2025 11:59

Altahrim force-pushed the feat/restrict-tag-creation branch from 4840a06 to dc9f724 Compare January 20, 2025 12:07

nextcloud-command force-pushed the feat/restrict-tag-creation branch from b7a29e3 to ff81fb9 Compare January 20, 2025 19:27

Altahrim mentioned this pull request Jan 21, 2025

31.0.0 beta 5 #50285

Merged

nfebe force-pushed the feat/restrict-tag-creation branch from ff81fb9 to a0b0ea3 Compare January 21, 2025 09:34

artonge reviewed Jan 21, 2025

View reviewed changes

Comment thread apps/settings/lib/Settings/Admin/Server.php Outdated

Altahrim force-pushed the feat/restrict-tag-creation branch from cd5a4a8 to 7c4295c Compare January 21, 2025 13:26

artonge approved these changes Jan 21, 2025

View reviewed changes

nfebe force-pushed the feat/restrict-tag-creation branch from 55cb8bb to b18f4d7 Compare January 22, 2025 19:01

Altahrim and others added 3 commits January 22, 2025 20:07

feat(systemtags): add setting to block non admin to create system tags

b4e3eff

Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>

feat(systemtags): toggle for system tag creation in admin settings

f7c46b6

Signed-off-by: nfebe <fenn25.fn@gmail.com>

feat: Update UI to respect tag creation permissions

abf840b

Added support for the `only_admin_can_create` flag in system tags. The UI now hides the option to create tags when this flag is enabled, ensuring compliance with admin settings. Signed-off-by: nfebe <fenn25.fn@gmail.com>

nfebe force-pushed the feat/restrict-tag-creation branch from 543c295 to abf840b Compare January 22, 2025 19:13

chore(assets): Recompile assets

00fbbf9

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Altahrim merged commit c10b8e2 into master Jan 22, 2025

Altahrim deleted the feat/restrict-tag-creation branch January 22, 2025 19:39

Altahrim mentioned this pull request Jan 23, 2025

31.0.0 RC1 #50329

Merged

skjnldsv mentioned this pull request Mar 5, 2025

[Bug]: Multiple bugs concerning tags #51233

Closed

9 tasks

skjnldsv reviewed Mar 5, 2025

View reviewed changes

susnux moved this from 🏗️ In progress to ☑️ Done in 📁 Files team Mar 14, 2025

Uh oh!

Uh oh!

Conversation

Altahrim commented Nov 27, 2024 • edited by nfebe Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

TODO

Checklist

Uh oh!

nfebe commented Jan 6, 2025

Frontend switch

Error view

Uh oh!

provokateurin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nfebe commented Jan 18, 2025

Uh oh!

nfebe commented Jan 21, 2025

Uh oh!

artonge left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Altahrim commented Jan 21, 2025

Uh oh!

nfebe commented Jan 22, 2025

Uh oh!

nfebe commented Jan 22, 2025

Uh oh!

skjnldsv Mar 5, 2025

Choose a reason for hiding this comment

Uh oh!

skjnldsv Mar 5, 2025

Choose a reason for hiding this comment

Uh oh!

skjnldsv Mar 5, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Altahrim commented Nov 27, 2024 •

edited by nfebe

Loading