fix: don't use cached root info from shared cache if the watcher has detected an update - #50324
Merged
Conversation
icewind1991
force-pushed
the
shared-cache-watcher-update
branch
from
February 6, 2025 18:40
5998665 to
8483886
Compare
…detected an update Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
shared-cache-watcher-update
branch
from
February 6, 2025 18:41
8483886 to
65a10f2
Compare
icewind1991
marked this pull request as ready for review
February 7, 2025 12:33
icewind1991
requested review from
a team,
nfebe,
skjnldsv and
yemkareems
and removed request for
a team
February 7, 2025 12:33
come-nc
approved these changes
Feb 11, 2025
Member
Author
|
/backport to stable31 |
Member
Author
|
/backport to stable30 |
2 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP: still want to add some tests