Enh/apply rector set to apps - #50577
Merged
Merged
Conversation
come-nc
requested review from
ChristophWurst,
SebastianKrupinski,
hamza221,
kesselb,
miaulalala,
nickvergessen,
st3iny and
tcitworld
as code owners
January 30, 2025 16:20
This comment was marked as outdated.
This comment was marked as outdated.
come-nc
added
2. developing
nickvergessen
previously requested changes
Jan 31, 2025
come-nc
force-pushed
the
enh/apply-rector-set-to-apps
branch
from
February 3, 2025 14:36
92966bf to
e37fb47
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
come-nc
force-pushed
the
enh/apply-rector-set-to-apps
branch
from
February 6, 2025 09:53
e37fb47 to
02ed6dd
Compare
Contributor
Author
|
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
force-pushed
the
enh/apply-rector-set-to-apps
branch
from
February 13, 2025 10:47
02ed6dd to
64863c9
Compare
…ME comment Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
added
3. to review
Contributor
Author
|
CI is green, this is now ready for review. |
skjnldsv
approved these changes
Feb 13, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NextcloudSets::NEXTCLOUD_25to configurationYou can note that
\OC::$server->getcalls are correctly replaced but not\OC::$server->queryones, that’s an oversight of the Set and will need to be fixed upstream.Apart from that the changes look sound to me.
Checklist