fix(comments): Do not set parent when instantiating activity tab plugin - #53267
Merged
artonge merged 1 commit intoJun 2, 2025
Merged
Conversation
artonge
requested review from
nfebe,
susnux and
szaimen
and removed request for
a team
June 2, 2025 15:17
2 tasks
This is necessary as the `context` variable is a vue3 instance, and vue 2 do not know how to handle it properly. Also, as far as I understand it, it is not needed. Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge
force-pushed
the
artonge/fix/do_not_pass_parent_for_activity_tab_comments_plugin
branch
from
June 2, 2025 16:00
65faecc to
40244ba
Compare
artonge
deleted the
artonge/fix/do_not_pass_parent_for_activity_tab_comments_plugin
branch
June 2, 2025 16:54
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is necessary as the
contextvariable is a vue3 instance, and vue 2 do not know how to handle it properly.Also, as far as I understand it, it is not needed.