feat: Implement custom Updater for object store storage#53423
Open
artonge wants to merge 3 commits into
Open
Conversation
artonge
force-pushed
the
artonge/feat/implement_custom_updater_for_object_storage
branch
3 times, most recently
from
June 10, 2025 15:56
2a8347a to
2e58d36
Compare
icewind1991
force-pushed
the
artonge/feat/implement_custom_updater_for_object_storage
branch
3 times, most recently
from
June 13, 2025 14:45
777885a to
dc0b4d4
Compare
Member
|
I think this is complete now, but I don't know if @artonge had anything more planned |
artonge
force-pushed
the
artonge/feat/implement_custom_updater_for_object_storage
branch
from
June 17, 2025 09:22
dc0b4d4 to
bc81da8
Compare
artonge
added
bug
3. to review
Collaborator
Author
|
/backport to stable31 |
artonge
force-pushed
the
artonge/feat/implement_custom_updater_for_object_storage
branch
from
June 17, 2025 09:36
bc81da8 to
20d4008
Compare
artonge
marked this pull request as ready for review
June 17, 2025 12:30
artonge
requested review from
Altahrim,
come-nc and
icewind1991
and removed request for
a team
June 17, 2025 12:30
come-nc
requested changes
Jun 17, 2025
artonge
force-pushed
the
artonge/feat/implement_custom_updater_for_object_storage
branch
2 times, most recently
from
June 17, 2025 14:03
2e82b22 to
914b44d
Compare
come-nc
approved these changes
Jun 19, 2025
Add a custom wrapper around the Updater for ObjectStoreStorage. This wrapper will skip updating the cache in some scenario. This is because a lot of cache management is already done in ObjectStoreStorage, so this will prevent heavy operations. Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
artonge/feat/implement_custom_updater_for_object_storage
branch
from
June 24, 2025 16:47
914b44d to
82f43ba
Compare
Signed-off-by: Robin Appelman <robin@icewind.nl>
Merged
Merged
This was referenced Sep 25, 2025
Merged
Merged
Merged
This was referenced Jan 29, 2026
Merged
Merged
Member
|
/backport to stable32 |
Member
|
/backport to stable33 |
Collaborator
Author
|
Would prefer to have a look again, this is really old 🙈 |
This was referenced Feb 11, 2026
Merged
Merged
Merged
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Custom Updater class for
ObjectStoreStorage.This wrapper will do nothing when the
updatemethod is called.This is to skip heavy cache operations, as they are already done in
ObjectStoreStorage.Replaces #52998