refactor(IMimeTypeDetector): streamline + minor tidying - #54077
Merged
Conversation
joshtrichards
added
2. developing
joshtrichards
added
3. to review
joshtrichards
marked this pull request as ready for review
July 24, 2025 16:58
joshtrichards
requested review from
nfebe,
salmart-dev and
sorbaugh
and removed request for
a team
July 24, 2025 16:58
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
force-pushed
the
jtr-files-detection-refactor-finfo
branch
from
August 4, 2025 15:24
20b1748 to
3535149
Compare
joshtrichards
changed the title
susnux
approved these changes
Aug 5, 2025
come-nc
approved these changes
Aug 5, 2025
come-nc
left a comment
come-nc
left a comment
Contributor
There was a problem hiding this comment.
Was the finfo slowness thing reported upstream to PHP?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FILEINFO_MIME+ extra string parsing to outright usingFILEINFO_MIME_TYPEfinfoUnrelated (in terms of this PR itself since it's true even before these changes, but something that came up during testing): PHP v8.4.1-v8.4.10 (current) appear to have dramatically slower
finfoperformance for some reason (like -2x+).TODO
Checklist