perf: use more optimized node-by-id logic in View::getPath - #54384
Merged
Conversation
icewind1991
requested review from
ArtificialOwl,
leftybournes and
yemkareems
and removed request for
a team
August 12, 2025 13:31
icewind1991
force-pushed
the
getpath-node
branch
4 times, most recently
from
August 12, 2025 15:53
3822d6d to
307ee80
Compare
CarlSchwan
approved these changes
Aug 13, 2025
icewind1991
force-pushed
the
getpath-node
branch
3 times, most recently
from
August 13, 2025 11:32
8637b61 to
8443cb1
Compare
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
getpath-node
branch
from
August 13, 2025 17:42
8443cb1 to
06154dd
Compare
come-nc
approved these changes
Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should hopefully provide some improved performance for all code still using the old code.