perf(base): Stop setting up the FS for every basic auth request - #54803
Open
provokateurin wants to merge 4 commits into
Open
perf(base): Stop setting up the FS for every basic auth request#54803provokateurin wants to merge 4 commits into
provokateurin wants to merge 4 commits into
Conversation
provokateurin
requested review from
nfebe,
sorbaugh,
susnux,
szaimen and
yemkareems
and removed request for
a team
September 2, 2025 12:12
Member
Author
|
/compile |
1 task
Member
|
Member
Author
susnux
approved these changes
Sep 2, 2025
provokateurin
marked this pull request as draft
September 2, 2025 16:27
szaimen
requested review from
come-nc and
skjnldsv
and removed request for
szaimen
September 3, 2025 09:04
Member
Author
|
Deck will also need a testing PR for this branch, as it relies on the same logic that is currently breaking Talk sharing tests (but I already have a solution): https://github.com/nextcloud/spreed/actions/runs/17404020365/job/49403633071?pr=15777 |
provokateurin
force-pushed
the
perf/base/basic-auth-fs-setup
branch
from
September 8, 2025 14:54
6511d14 to
7500e26
Compare
Member
Author
Member
Author
|
I ran all the failing Talk and Deck integration tests locally, but they all pass 🙈 I double checked that I'm really using the correct branches, but it was all as intended. |
This was referenced Sep 16, 2025
provokateurin
force-pushed
the
perf/base/basic-auth-fs-setup
branch
3 times, most recently
from
October 2, 2025 08:46
aced6e3 to
0786ca8
Compare
6 tasks
Member
Author
|
I think this PR could be unblocked by #57295, as I was stuck on the VerifyMountPointEvent last time 🎉 |
provokateurin
force-pushed
the
perf/base/basic-auth-fs-setup
branch
from
February 24, 2026 09:17
0786ca8 to
df380d0
Compare
susnux
reviewed
May 15, 2026
susnux
left a comment
Contributor
There was a problem hiding this comment.
@provokateurin do we still need the cache mount then?
Member
Author
|
I'm not sure what you mean and how this is related 🤔 |
CarlSchwan
approved these changes
Jun 10, 2026
CarlSchwan
force-pushed
the
perf/base/basic-auth-fs-setup
branch
from
June 10, 2026 15:09
df380d0 to
f73fb1f
Compare
CarlSchwan
reviewed
Jun 10, 2026
come-nc
approved these changes
Jun 10, 2026
come-nc
force-pushed
the
perf/base/basic-auth-fs-setup
branch
2 times, most recently
from
June 18, 2026 09:27
01ea5fa to
ac5dc70
Compare
come-nc
reviewed
Jun 18, 2026
CarlSchwan
marked this pull request as ready for review
June 23, 2026 12:35
CarlSchwan
force-pushed
the
perf/base/basic-auth-fs-setup
branch
from
June 23, 2026 12:35
ac5dc70 to
c5a47a8
Compare
Signed-off-by: provokateurin <kate@provokateurin.de>
… local cache Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
force-pushed
the
perf/base/basic-auth-fs-setup
branch
from
June 23, 2026 12:42
c5a47a8 to
0c0bf73
Compare
come-nc
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One more time, we're gonna celebrate 🎵 ✌️ (last time, I promise 🤞)
Needs nextcloud/guests#1400 to not break the Guests app.
Nothing needed to change on the server side, it's the exact same changes as with the last PR.