[stable31] fix: Dispatch favorite event with an actual path - #55126
Merged
Conversation
backportbot
Bot
requested review from
AndyScherzinger,
artonge and
provokateurin
September 15, 2025 14:38
backportbot
Bot
added
bug
3. to review
The `$path` argument was added in #48612, but was never actually used by the callers. The path was therefore missing in the favorite/unfavorite events, which lead to a broken activity information. I also added a fallback to handle `addToFavorites` and `removeFromFavorites`, which are part of a public API, and are calling `tagAs` and `untag` without `$path`. Fix nextcloud/activity#2134 Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge
force-pushed
the
backport/55122/stable31
branch
from
September 15, 2025 14:52
fd6ce5f to
d7775cb
Compare
artonge
approved these changes
Sep 15, 2025
It was not caught by the CI on master, but is blocking in the backports. Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge
marked this pull request as ready for review
September 15, 2025 15:10
CarlSchwan
approved these changes
Sep 15, 2025
AndyScherzinger
enabled auto-merge
September 15, 2025 16:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #55122
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.