refactor: use logical && || instead of weak and or operators - #55363
Merged
Conversation
susnux
added
3. to review
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
refactor/weak-operators
branch
from
September 27, 2025 21:02
ec5ee2c to
64b31bb
Compare
susnux
marked this pull request as ready for review
September 28, 2025 09:22
susnux
requested review from
come-nc,
kesselb,
nfebe,
nickvergessen and
provokateurin
and removed request for
a team
September 28, 2025 09:22
provokateurin
approved these changes
Sep 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Weak operators like
andandorare misleading as they work different as most people expect them to work.So migrate to consistent usage of logical operators like
&&and||.See also https://www.php.net/manual/en/language.operators.precedence.php
Checklist
3. to review, feature component)stable32)