fix: Fetching previews on Oracle - #55954
Merged
Merged
Conversation
We need an explicit cast on Oracle as Oracle returns number as string. Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
CarlSchwan
requested review from
Altahrim,
leftybournes,
salmart-dev and
yemkareems
and removed request for
a team
October 23, 2025 07:39
come-nc
approved these changes
Oct 23, 2025
nickvergessen
approved these changes
Oct 23, 2025
CarlSchwan
force-pushed
the
carl/fix-preview2
branch
2 times, most recently
from
October 23, 2025 10:14
f4879a7 to
98b2416
Compare
susnux
approved these changes
Oct 23, 2025
Contributor
|
Sharding errors sound similar like this: #53779 (comment) |
CarlSchwan
force-pushed
the
carl/fix-preview2
branch
from
October 23, 2025 11:11
98b2416 to
ed5c0e2
Compare
CarlSchwan
force-pushed
the
carl/fix-preview2
branch
3 times, most recently
from
October 23, 2025 11:44
486f9af to
3597b36
Compare
Split the DB requests in chunk of 1000 and use INNER JOIN instead of IN as this is better supported on all DB. Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
CarlSchwan
force-pushed
the
carl/fix-preview2
branch
from
October 23, 2025 12:10
3597b36 to
1dc3635
Compare
Member
|
Can/should this be backported as the issue #53779 is from 32 or even 31 already? |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We need an explicit cast on Oracle as Oracle returns number as string.
Checklist
3. to review, feature component)stable32)