fix(contacts): allow address book to be local but not system - #56240
Merged
Conversation
1 task
Member
|
could we find a positive name, that describes what it is? |
ArtificialOwl
force-pushed
the
fix/noid/set-adr-book-local-but-not-system
branch
from
November 12, 2025 11:32
3fe5a94 to
bd6fb93
Compare
Member
Author
totally agree; fun fact, I had the exact same name in mind but forgot to force push :D |
ArtificialOwl
marked this pull request as ready for review
November 12, 2025 11:45
ArtificialOwl
requested review from
CarlSchwan,
icewind1991 and
salmart-dev
and removed request for
a team
November 12, 2025 11:45
ArtificialOwl
force-pushed
the
fix/noid/set-adr-book-local-but-not-system
branch
from
November 19, 2025 14:44
bd6fb93 to
6edf519
Compare
ArtificialOwl
requested review from
SebastianKrupinski and
hamza221
as code owners
November 19, 2025 14:44
ArtificialOwl
force-pushed
the
fix/noid/set-adr-book-local-but-not-system
branch
from
November 19, 2025 14:45
6edf519 to
b2a3448
Compare
blizzz
approved these changes
Nov 20, 2025
ArtificialOwl
force-pushed
the
fix/noid/set-adr-book-local-but-not-system
branch
2 times, most recently
from
December 22, 2025 12:58
10824a4 to
8202cd9
Compare
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
ArtificialOwl
force-pushed
the
fix/noid/set-adr-book-local-but-not-system
branch
from
December 22, 2025 13:37
8202cd9 to
b281764
Compare
CarlSchwan
approved these changes
Dec 22, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if set as local system address book, a userId is expected in some place like
server/lib/private/Collaboration/Collaborators/MailPlugin.php
Lines 114 to 134 in 77194d5
This fix allow app like
ldap_contacts_backendto using a new configuration key to set itself as a local non-system address booknextcloud/ldap_contacts_backend#350