Fix potentially broken shares from the past - #56243
Merged
Merged
Conversation
julien-nc
requested review from
icewind1991,
leftybournes and
salmart-dev
and removed request for
a team
November 6, 2025 12:31
julien-nc
force-pushed
the
fix/noid/share-permissions-attribute
branch
from
November 6, 2025 12:34
7f0379e to
43ee50e
Compare
ArtificialOwl
approved these changes
Nov 6, 2025
ArtificialOwl
left a comment
Member
There was a problem hiding this comment.
attributes are not indexed, maybe a check on share_type=7 for faster operation ?
julien-nc
force-pushed
the
fix/noid/share-permissions-attribute
branch
2 times, most recently
from
November 7, 2025 09:06
197c1ef to
cd79e73
Compare
Member
Author
|
@ArtificialOwl Done, thanks |
julien-nc
force-pushed
the
fix/noid/share-permissions-attribute
branch
from
November 12, 2025 12:38
cd79e73 to
e4414c4
Compare
marcelklehr
approved these changes
Nov 12, 2025
julien-nc
force-pushed
the
fix/noid/share-permissions-attribute
branch
4 times, most recently
from
November 14, 2025 16:22
130caab to
efa639f
Compare
…ll' download permission to 'true' Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
julien-nc
force-pushed
the
fix/noid/share-permissions-attribute
branch
from
November 17, 2025 09:07
efa639f to
8b3e59f
Compare
Member
|
Member
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change 'null' download permission to 'true'.
A 'null' download permission has been seen in some team shares in the past. Now that such shares are not created anymore, the ones that were created before the fix are still hanging there.
The problem is that there is a behaviour inconsistency when this permission is null:
Should this migration rather be in the files_sharing app?