Skip to content

Add api for authoritative mount providers and implement it for files_external - #56499

Merged
icewind1991 merged 13 commits into
masterfrom
authoritative-mount-provider-files_external
Jan 13, 2026
Merged

Add api for authoritative mount providers and implement it for files_external#56499
icewind1991 merged 13 commits into
masterfrom
authoritative-mount-provider-files_external

Conversation

@icewind1991

@icewind1991 icewind1991 commented Nov 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Member
  • Add the api surface for mount providers to pro-actively update the list of cached mounts
  • Implement this for files_external as POC since it's one of the easiest ones

Note that this only adds the api for implementing authoritative mounts providers, it doesn't add any logic that rely on them.

TODO:

  • deal with new users, group changes, etc
  • don't get the root cache entry multiple times if there is no user-specific config

Best used with #56447 to easily see the mount listing

@icewind1991 icewind1991 added the 2. developing Work in progress label Nov 17, 2025
@icewind1991
icewind1991 force-pushed the authoritative-mount-provider-files_external branch 3 times, most recently from fbbbc26 to 3f1e180 Compare November 26, 2025 18:04
CarlSchwan
CarlSchwan reviewed Dec 10, 2025
View reviewed changes
Comment thread apps/files_external/lib/Service/GlobalStoragesService.php Outdated
Comment thread apps/files_external/lib/Service/GlobalStoragesService.php
Comment thread apps/files_external/lib/Service/GlobalStoragesService.php Outdated
Comment thread apps/files_external/lib/Service/MountCacheService.php Outdated
Comment thread apps/files_external/lib/Service/MountCacheService.php Outdated
Comment thread apps/files_external/lib/Service/MountCacheService.php Outdated
Comment thread apps/files_external/lib/Service/MountCacheService.php Outdated
Comment thread apps/files_external/lib/Service/MountCacheService.php Outdated
@icewind1991
icewind1991 force-pushed the authoritative-mount-provider-files_external branch 8 times, most recently from 21677d9 to 3870269 Compare December 22, 2025 15:41
@icewind1991 icewind1991 added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Dec 22, 2025
@icewind1991 icewind1991 added this to the Nextcloud 33 milestone Dec 22, 2025
@icewind1991
icewind1991 marked this pull request as ready for review December 22, 2025 15:41
@icewind1991
icewind1991 requested a review from a team as a code owner December 22, 2025 15:41
@icewind1991
icewind1991 requested review from come-nc, nfebe, provokateurin and salmart-dev and removed request for a team December 22, 2025 15:41
@icewind1991
icewind1991 force-pushed the authoritative-mount-provider-files_external branch from 3870269 to e16d968 Compare December 31, 2025 17:11
@icewind1991
icewind1991 requested a review from a team as a code owner January 2, 2026 16:24
@icewind1991
icewind1991 requested review from susnux and removed request for a team January 2, 2026 16:24
@icewind1991
icewind1991 force-pushed the authoritative-mount-provider-files_external branch from 2f2f661 to e7a71e3 Compare January 2, 2026 16:30
@nextcloud-bot nextcloud-bot mentioned this pull request Jan 7, 2026
Merged
artonge
artonge reviewed Jan 7, 2026
View reviewed changes
Comment thread lib/public/Files/Config/IUserMountCache.php Outdated
Comment thread lib/public/Files/Config/IUserMountCache.php Outdated
Comment thread lib/private/Files/Config/UserMountCache.php
Comment thread apps/files_external/lib/Service/MountCacheService.php Outdated
Comment thread apps/files_external/lib/Service/MountCacheService.php Outdated
Comment thread apps/files_external/lib/Service/MountCacheService.php Outdated
Comment thread apps/files_external/lib/Service/MountCacheService.php Outdated
Comment thread apps/files_external/lib/Service/MountCacheService.php Outdated
Comment thread apps/files_external/lib/Service/MountCacheService.php Outdated
Comment thread apps/files_external/lib/Service/MountCacheService.php Outdated
@icewind1991
icewind1991 force-pushed the authoritative-mount-provider-files_external branch from e7a71e3 to 1943112 Compare January 7, 2026 17:57
artonge
artonge reviewed Jan 8, 2026
View reviewed changes

@artonge artonge left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last comment, else it looks good to merge :)

Comment thread apps/files_external/lib/Lib/ApplicableHelper.php Outdated
@icewind1991
icewind1991 force-pushed the authoritative-mount-provider-files_external branch 3 times, most recently from 2a31f52 to 0dcb693 Compare January 8, 2026 15:56
@icewind1991
icewind1991 force-pushed the authoritative-mount-provider-files_external branch 2 times, most recently from 254a73f to d9ed362 Compare January 8, 2026 21:28
@nextcloud-bot nextcloud-bot mentioned this pull request Jan 9, 2026
Merged
@icewind1991
feat: add interface to mark mount providers as authoritative
198d500 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
feat: add api for authoritative mount providers to update the user mo…
e3551e5 
…unts

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
feat: add typed events for external storage config changes
c80c980 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
feat: yield user by id in IUserManager::getSeenUsers
765d1af 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
feat: make external storage mount provider authoritative
5565cdb 
Signed-off-by: Robin Appelman <robin@icewind.nl>

# Conflicts:
#	apps/files_external/lib/AppInfo/Application.php
@icewind1991
feat: listen to user/group events and update external storage mounts
d64f7eb 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
perf: cache root cache entries for external storage in MountCacheService
73e84f9 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
fix: improve handling of unavailable storages
9dffca2 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
fix: update external storage mounts on login
6dd6d06 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
fix: don't error when checking login credential storage from cli
fa61c4c 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
test: update cypress test for new files_external mount behavior
c14948f 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
fix: better applicable check for updating external mounts
be3bbf2 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
fix: improve handling updated storages
272d614 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
icewind1991 force-pushed the authoritative-mount-provider-files_external branch from d9ed362 to 272d614 Compare January 9, 2026 16:54
@icewind1991 icewind1991 mentioned this pull request Jan 13, 2026
Merged
4 tasks
@icewind1991
icewind1991 merged commit ae74dbe into master Jan 13, 2026
239 of 248 checks passed
@icewind1991
icewind1991 deleted the authoritative-mount-provider-files_external branch January 13, 2026 15:36
@artonge artonge mentioned this pull request Jan 21, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artonge artonge artonge approved these changes
@CarlSchwan CarlSchwan CarlSchwan approved these changes
@salmart-dev salmart-dev Awaiting requested review from salmart-dev salmart-dev is a code owner automatically assigned from nextcloud/server-backend
@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-backend
@provokateurin provokateurin Awaiting requested review from provokateurin provokateurin is a code owner automatically assigned from nextcloud/server-backend
@come-nc come-nc Awaiting requested review from come-nc come-nc is a code owner automatically assigned from nextcloud/server-backend
@susnux susnux Awaiting requested review from susnux susnux is a code owner automatically assigned from nextcloud/server-frontend

Assignees

No one assigned

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

Nextcloud 33

Development

Successfully merging this pull request may close these issues.

3 participants

@icewind1991 @artonge @CarlSchwan