fix(trashbin): deletedBy of a file from a federated folder - #56668
Merged
Conversation
ArtificialOwl
force-pushed
the
fix/noid/real-account-on-deleted-federation
branch
2 times, most recently
from
November 25, 2025 17:11
225735b to
690c878
Compare
ArtificialOwl
marked this pull request as ready for review
November 26, 2025 09:18
ArtificialOwl
requested review from
Altahrim,
salmart-dev and
yemkareems
and removed request for
a team
November 26, 2025 09:18
ArtificialOwl
force-pushed
the
fix/noid/real-account-on-deleted-federation
branch
from
November 26, 2025 09:19
690c878 to
ce32c06
Compare
AndyScherzinger
added
enhancement
3. to review
Signed-off-by: Maxence Lange <maxence@artificial-owl.com> d
ArtificialOwl
force-pushed
the
fix/noid/real-account-on-deleted-federation
branch
from
December 1, 2025 17:25
ce32c06 to
ea8b133
Compare
| try { | ||
| $request = Server::get(IRequest::class); | ||
| /** @psalm-suppress NoInterfaceProperties */ | ||
| $token = $request->server['PHP_AUTH_USER'] ?? ''; |
Member
There was a problem hiding this comment.
Would this somehow allow forging the value, so it looks like someone else deleted the file?
Member
Author
There was a problem hiding this comment.
If the webdav request is authed, it might be by using the share token.
I only check if this is the case so I can assign a name to the deleter.
Yes, if you know the share token, you can delete the file (if the share has permission), but this is the expected behavior
Member
Author
|
/backport to stable32 |
Member
Author
|
/backport to stable31 |
AndyScherzinger
approved these changes
Dec 4, 2025
This was referenced Dec 4, 2025
Merged
ArtificialOwl
enabled auto-merge
December 4, 2025 12:26
nfebe
approved these changes
Dec 4, 2025
This was referenced Dec 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If coming from a federated folder, the share token is used to auth the webdav delete request.
Before creating new entry in the trashbin table, checking if file was deleted remotely using
IRequest.In case the token is a valid share token, using sharedWith to set deletedBy.
However deletedBy is now a remote entity but front-end will still displays 'Unknown', which is still better than 'You'