fix(files): correctly handle nodes with snowflake ids - #58611
Merged
Conversation
susnux
requested review from
artonge and
szaimen
and removed request for
a team
February 27, 2026 14:38
Contributor
Author
|
/backport to stable33 |
CarlSchwan
approved these changes
Mar 1, 2026
CarlSchwan
force-pushed
the
fix/files-snowflake
branch
from
March 2, 2026 12:18
b48ad9d to
98c4a1a
Compare
Member
|
/compile |
susnux
force-pushed
the
fix/files-snowflake
branch
from
March 2, 2026 13:56
60cabe0 to
33e7231
Compare
artonge
approved these changes
Mar 3, 2026
susnux
force-pushed
the
fix/files-snowflake
branch
from
March 3, 2026 12:24
33e7231 to
4416d9a
Compare
Contributor
Author
|
/compile rebase |
nextcloud-command
force-pushed
the
fix/files-snowflake
branch
from
March 3, 2026 15:47
4416d9a to
848664d
Compare
skjnldsv
approved these changes
Mar 10, 2026
Contributor
Author
|
/compile rebase |
nextcloud-command
force-pushed
the
fix/files-snowflake
branch
from
March 10, 2026 17:54
848664d to
17afe6a
Compare
We introduced `id` instead of `fileid` to be always of type `string` to allow snow flake ids. So we need to check the new attribute instead of the legacy one. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/files-snowflake
branch
from
March 16, 2026 18:40
17afe6a to
6dfeeff
Compare
Contributor
Author
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
skjnldsv
approved these changes
Mar 17, 2026
| subscribe('files:node:deleted', fileStore.onDeletedNode) | ||
| subscribe('files:node:updated', fileStore.onUpdatedNode) | ||
| subscribe('files:node:moved', fileStore.onMovedNode) | ||
| export const useFilesStore = defineStore('files', () => { |
Member
There was a problem hiding this comment.
I used to remember I had to ensure the args were forwarded. But it seems to work here, so let's go this!
Contributor
Author
There was a problem hiding this comment.
Yeah its again a rabbit hole...
I had to do more than I hoped for to make TS happy and Cypress green...
susnux
enabled auto-merge
March 17, 2026 11:53
2 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We introduced
idinstead offileidto be always of typestringto allow snow flake ids. So we need to check the new attribute instead of the legacy one.Checklist
3. to review, feature component)stable32)AI (if applicable)