fix(theming): deprecate OCA.Theming and move to capabilities - #59089
Merged
Conversation
skjnldsv
requested review from
CarlSchwan,
leftybournes,
provokateurin and
sorbaugh
and removed request for
a team
March 19, 2026 18:08
skjnldsv
force-pushed
the
fix/expand-theming-capabilities
branch
from
March 19, 2026 18:08
f96535b to
6c7b1c5
Compare
susnux
approved these changes
Mar 19, 2026
skjnldsv
force-pushed
the
fix/expand-theming-capabilities
branch
from
March 19, 2026 18:43
6c7b1c5 to
ecfb95a
Compare
susnux
reviewed
Mar 19, 2026
susnux
reviewed
Mar 19, 2026
Member
Author
|
Ah sorry, didn't see you already approved |
susnux
approved these changes
Mar 19, 2026
skjnldsv
force-pushed
the
fix/expand-theming-capabilities
branch
7 times, most recently
from
March 24, 2026 13:12
7969d1e to
57fdce7
Compare
skjnldsv
requested review from
ChristophWurst,
SebastianKrupinski and
tcitworld
as code owners
March 24, 2026 13:12
skjnldsv
force-pushed
the
fix/expand-theming-capabilities
branch
from
March 24, 2026 13:13
57fdce7 to
de953f1
Compare
Member
Author
|
Sorry for the external team ping, rector was complaining so I ran it and it adjusted some dav php files 🙈 |
skjnldsv
force-pushed
the
fix/expand-theming-capabilities
branch
from
March 24, 2026 14:12
de953f1 to
c180632
Compare
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de> Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
fix/expand-theming-capabilities
branch
from
March 24, 2026 14:24
c180632 to
04d9f79
Compare
come-nc
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We should refrain from using
OCA.ThemingWe should be able to do everything we want with capabilities
Checklist
3. to review, feature component)stable32)AI (if applicable)