fix(settings): sort app list by app name instead of app objects - #59848
Merged
Conversation
Member
Author
|
/compile / |
joshtrichards
marked this pull request as ready for review
April 22, 2026 14:37
joshtrichards
requested review from
nfebe,
sorbaugh and
szaimen
and removed request for
a team
April 22, 2026 14:37
DorraJaouad
requested review from
a team,
SebastianKrupinski,
hamza221,
mgallien,
miaulalala,
nickvergessen and
provokateurin
as code owners
April 23, 2026 09:41
miaulalala
approved these changes
Apr 23, 2026
miaulalala
left a comment
miaulalala
left a comment
Contributor
There was a problem hiding this comment.
neat 
Dist conflicts, please rebase 🙏
nickvergessen
removed request for
a team,
SebastianKrupinski,
hamza221,
leftybournes,
mgallien,
nickvergessen and
provokateurin
April 24, 2026 09:21
Contributor
|
/compile rebase |
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
jtr/fix-settings-sort-list
branch
from
April 29, 2026 12:31
04a1043 to
ccdd49e
Compare
Contributor
|
/backport to stable33 |
3 tasks
This was referenced May 15, 2026
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #Summary
This is fixing a "it works by accident" scenario. 😄 Fix app list sorting in
apps/settings/src/components/AppList.vueby passingapp.nametoOC.Util.naturalSortCompareinstead of the full app object.Why
OC.Util.naturalSortCompareexpects strings, but the current code passes app objects. As a result,chunkifyreturns an empty array and the natural sort is effectively a no-op, so the comparator falls back to the existing status-bucket ordering.The UI often still appeared correct because the backend already returns
/settings/apps/listalphabetically byname.That behavior becomes especially fragile when combining regular apps with ExApps, since each backend list may already be individually sorted, but the concatenated combined list is not guaranteed to be globally sorted unless the frontend explicitly sorts by
name.Changes
OC.Util.naturalSortCompare(a, b)withOC.Util.naturalSortCompare(a.name, b.name)Result
Sorting should remain the same from a user perspective in normal cases, but the implementation is now explicit, type-correct, and stable when mixing regular apps and ExApps.
Related
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)