Skip to content

refactor: Remove old deprecated methods from OCP\Calendar - #60955

Open
CarlSchwan wants to merge 2 commits into
masterfrom
carl/room-resource-deprecation
Open

refactor: Remove old deprecated methods from OCP\Calendar#60955
CarlSchwan wants to merge 2 commits into
masterfrom
carl/room-resource-deprecation

Conversation

@CarlSchwan

Copy link
Copy Markdown
Member
  • Resolves: #

Summary

TODO

  • ...

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@CarlSchwan CarlSchwan added this to the Nextcloud 35 milestone Jun 3, 2026
@CarlSchwan CarlSchwan self-assigned this Jun 3, 2026
@CarlSchwan CarlSchwan added 3. to review Waiting for reviews technical debt 🧱 🤔🚀 pending documentation This pull request needs an associated documentation update labels Jun 3, 2026
@CarlSchwan
CarlSchwan requested review from Altahrim, artonge, icewind1991 and provokateurin and removed request for a team June 3, 2026 09:17
@CarlSchwan
CarlSchwan force-pushed the carl/room-resource-deprecation branch from b8f2a10 to 5d94340 Compare June 3, 2026 11:03

@artonge artonge left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also wait for the documentation PR before merging that one.

@CarlSchwan

Copy link
Copy Markdown
Member Author

Let's also wait for the documentation PR before merging that one.

nextcloud/documentation#15066

@CarlSchwan
CarlSchwan force-pushed the carl/room-resource-deprecation branch from 5d94340 to ce115ed Compare June 3, 2026 13:11
@SebastianKrupinski

SebastianKrupinski commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

@CarlSchwan

I believe this will break the calendar_resource_management app, did you test the app?

CarlSchwan added a commit to nextcloud/documentation that referenced this pull request Jun 4, 2026
@CarlSchwan

Copy link
Copy Markdown
Member Author

@CarlSchwan

I believe this will break the calendar_resource_management app, did you test the app?

This works only the update method is used and even with some if (method_exists). I cleaned this a bit up and added some phpstan

nextcloud/calendar_resource_management#260

Signed-off-by: Carl Schwan <carlschwan@kde.org>
@joshtrichards
joshtrichards force-pushed the carl/room-resource-deprecation branch from ce115ed to ad294dc Compare July 27, 2026 15:28
…rTest

Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards joshtrichards added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews pending documentation This pull request needs an associated documentation update labels Jul 27, 2026
@CarlSchwan
CarlSchwan enabled auto-merge July 27, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish technical debt 🧱 🤔🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants