fix(versions): preserve version encrypted version before rollback

[leftybournes]

• Resolves: [Bug]: Encrypted files become corrupted after restoring a version #61492

Summary

While rolling back, the created file version's encrypted version is set to 1 when it is actually higher, causing it to appear corrupted when restoring to it. This preserves the encrypted version for the created file version to prevent "corruption" from happening.

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)
• Labels added where applicable (ex: bug/enhancement, 3. to review, feature component)
• Milestone added for target branch/version (ex: 32.x for stable32)

AI (if applicable)

• The content of this PR was partly or fully generated using AI

[provokateurin]

encrypted should probably not get set or at least not to the version?

[leftybournes]

When I tested it, just setting encryptedVersion "corrupts" the version but also setting encrypted fixes the issue.

[joshtrichards]

I guess we already do some of this below too, but I feel like we should be letting the Encryption storage wrapper deal with these matters -- e.g.

server/lib/private/Files/Storage/Wrapper/Encryption.php

Lines 644 to 654 in 2da90a9

	private function copyBetweenStorage(
	Storage\IStorage $sourceStorage,
	string $sourceInternalPath,
	string $targetInternalPath,
	bool $preserveMtime,
	bool $isRename,
	): bool {
	// for versions we have nothing to do, because versions should always use the
	// key from the original file. Just create a 1:1 copy and done
	if ($this->isVersion($targetInternalPath)
	|| $this->isVersion($sourceInternalPath)) {

[leftybournes]

@joshtrichards I dug into it further and it seems it's already handled in the Encryption wrapper.

server/lib/private/Files/Storage/Wrapper/Encryption.php

Lines 631 to 637 in 2da90a9

	// in case of a rename we need to manipulate the source cache because
	// this information will be kept for the new target
	if ($isRename) {
	$sourceStorage->getCache()->put($sourceInternalPath, $cacheInformation);
	} else {
	$this->getCache()->put($targetInternalPath, $cacheInformation);
	}

The problem is the encryptedVersion value gets overwritten when a new version is created. I noticed a sequence where Encryption sets the encryptedVersion and then View calls a copyUpdate which overwrites the encryptedVersion value to 1 which is why this workaround is needed.

server/lib/private/Files/View.php

Lines 1000 to 1002 in 2da90a9

	if ($result) {
	$this->copyUpdate($storage1, $storage2, $internalPath1, $internalPath2);
	}

[joshtrichards]

This is begging for test coverage. :-)

[leftybournes]

After doing some further digging, I found the root cause and opened a new pull request. I'll close this if it's merged.

[leftybournes]

Closing this in favor of #62255