[stable33] fix(files): preserve encryptedVersion when copying cache entries - #62338
Merged
Conversation
backportbot
Bot
requested review from
Altahrim,
cristianscheid,
icewind1991,
leftybournes,
nfebe,
provokateurin and
sorbaugh
and removed request for
a team
July 20, 2026 10:52
backportbot
Bot
added
bug
3. to review
leftybournes
approved these changes
Jul 20, 2026
cristianscheid
approved these changes
Jul 20, 2026
leftybournes
force-pushed
the
backport/62255/stable33
branch
from
July 24, 2026 03:49
bc07e02 to
5531957
Compare
leftybournes
enabled auto-merge
July 24, 2026 03:49
Cache::copyFromCache() rebuilt the target's cache row via cacheEntryToArray(), which only carried over a boolean `encrypted` flag and dropped the real `encryptedVersion` count. Since View::copy() unconditionally calls copyFromCache() after the storage copy completes, this silently overwrote the correct encryptedVersion that Encryption::updateEncryptedVersion() had just set, collapsing it back to 0/1 on every copy of a file whose encryptedVersion was above 1. cacheEntryToArray() now includes the source entry's encryptedVersion when it is encrypted. The existing encrypted-to-non-encrypted-storage override in copyFromCache() also clears encryptedVersion alongside `encrypted`, since normalizeData() prefers encryptedVersion over `encrypted` when both are present in the update data. Signed-off-by: Kent Delante <kent@delante.me> Assisted-by: ClaudeCode:claude-sonnet-5
Signed-off-by: Kent Delante <kent@delante.me> Assisted-by: ClaudeCode:claude-sonnet-5
DerDreschner
force-pushed
the
backport/62255/stable33
branch
from
July 25, 2026 17:35
5531957 to
ba1d172
Compare
AndyScherzinger
disabled auto-merge
July 27, 2026 18:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #62255