[stable34] fix: Use PHP_AUTH_PW for strict password confirmation - #62537
[stable34] fix: Use PHP_AUTH_PW for strict password confirmation#62537backportbot[bot] wants to merge 2 commits into
Conversation
3a40951 to
b737ad2
Compare
|
Checked it quick and dirty in 33.0.3.2 and it fixed the problem. |
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
b737ad2 to
9c2ae17
Compare
|
/backport to stable33 |
|
/backport to stable32 |
come-nc
left a comment
There was a problem hiding this comment.
I dislike getting this though getHeader, it’s not a header per-se, is it?
It looks like the rest of the code uses $this->request->server['PHP_AUTH_USER'], which is ugly.
Would it make sense to have dedicated getters to get user and password from basic auth?
|
@come-nc I think that’s generally a good idea. I would even go one step further and remove the special key handling completely? since this is breaking, we should do it starting with 35? The only tricky one I can see right now is server/apps/settings/lib/SetupChecks/ForwardedForHeaders.php Lines 41 to 42 in cbdff85 to fix the linked issue, shall we therefore merge this? |
Backport of #62477
For easier testing in the community, since master cannot be directly applied.
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.