Skip to content

[stable34] fix(Database): Use real idle-timer to prevent lastInsertId being reset on MariaDB/MySQL - #62714

Merged
AndyScherzinger merged 1 commit into
stable34from
backport/62697/stable34
Aug 3, 2026
Merged

[stable34] fix(Database): Use real idle-timer to prevent lastInsertId being reset on MariaDB/MySQL#62714
AndyScherzinger merged 1 commit into
stable34from
backport/62697/stable34

Conversation

@backportbot

@backportbot backportbot Bot commented Jul 30, 2026

Copy link
Copy Markdown

Backport of PR #62697

…set on MariaDB/MySQL

The previous implementation of the idle timer runs on a strict 30 second interval and sends a dummy `SELECT` statement to keep the connection open.

This generates issues with the `lastInsertId` on long-running tasks (like our CI pipeline), as the MariaDB documentation clearly states:

> If the last query wasn't an INSERT or UPDATE statement or if the modified table does not have a column with the AUTO_INCREMENT attribute and LAST_INSERT_ID was not used, this function will return zero.

Source: https://mariadb.com/docs/connectors/mariadb-connector-c/api-functions/mysql_insert_id

To mitigate that, this commit now uses a real idle-timer per connection instead.

Assisted-by: ClaudeCode:claude-fable-5
Signed-off-by: David Dreschner <david.dreschner@nextcloud.com>
@backportbot
backportbot Bot requested a review from a team as a code owner July 30, 2026 16:34
@backportbot
backportbot Bot requested review from CarlSchwan, DerDreschner, leftybournes, nfebe, nickvergessen, provokateurin and sorbaugh and removed request for a team July 30, 2026 16:34
@backportbot backportbot Bot added bug 3. to review Waiting for reviews tests Related to tests CI feature: database Database related DB AI assisted labels Jul 30, 2026
@backportbot backportbot Bot added this to the Nextcloud 34.0.3 milestone Jul 30, 2026
@AndyScherzinger
AndyScherzinger merged commit 235ec7d into stable34 Aug 3, 2026
193 of 219 checks passed
@AndyScherzinger
AndyScherzinger deleted the backport/62697/stable34 branch August 3, 2026 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews AI assisted bug CI feature: database Database related DB tests Related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants