Skip to content

[stable34] fix(share): Avoid crash when share owner is not found #62798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
backportbot wants to merge 1 commit into
base: stable34
Choose a base branch
from
+19 −13
Open

[stable34] fix(share): Avoid crash when share owner is not found #62798

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 19 additions & 13 deletions lib/private/Share20/Share.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,10 @@
* SPDX-FileCopyrightText: 2016 ownCloud, Inc.
* SPDX-License-Identifier: AGPL-3.0-only
*/

namespace OC\Share20;

use OC\User\NoUserException;
use OCP\Constants;
use OCP\Files\Cache\ICacheEntry;
use OCP\Files\File;
Expand Down Expand Up @@ -133,20 +135,24 @@ public function getNode(): Node {
throw new NotFoundException();
}

// for federated shares the owner can be a remote user, in this
// case we use the initiator
if ($this->userManager->userExists($this->shareOwner)) {
$userFolder = $this->rootFolder->getUserFolder($this->shareOwner);
} else {
$userFolder = $this->rootFolder->getUserFolder($this->sharedBy);
try {
// for federated shares the owner can be a remote user, in this
// case we use the initiator
if ($this->userManager->userExists($this->shareOwner)) {
$userFolder = $this->rootFolder->getUserFolder($this->shareOwner);
} else {
$userFolder = $this->rootFolder->getUserFolder($this->sharedBy);
}

$node = $userFolder->getFirstNodeById($this->fileId);
if (!$node) {
throw new NotFoundException('Node for share not found, fileid: ' . $this->fileId);
}

$this->node = $node;
} catch (NoUserException $e) {
throw new NotFoundException('Owner for share not found, fileid: ' . $this->fileId, previous:$e);
}

$node = $userFolder->getFirstNodeById($this->fileId);
if (!$node) {
throw new NotFoundException('Node for share not found, fileid: ' . $this->fileId);
}

$this->node = $node;
}

return $this->node;
Expand Down
Loading