fix(search): Use OCP constants for filters - #10919
Merged
Merged
Conversation
nickvergessen
added
3. to review
feature: api 🛠️
Altahrim
approved these changes
Nov 17, 2023
Altahrim
left a comment
Altahrim
left a comment
There was a problem hiding this comment.
For your usage, maybe methods like getTerm, getSince etc would be easier to use.
I imagine psalm errors are related to stubs
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
bugfix/noid/use-OCP-constants-for-filters
branch
from
November 17, 2023 09:32
3a6ec72 to
1ceb3ee
Compare
Member
Author
Yes, couldn't update the package yesterday, fixed now
I don't see such methods in OCP, so getFilter() it is for now |
nickvergessen
enabled auto-merge
November 17, 2023 09:33
Not yet, just an idea I had in mind :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠️ API Checklist
🚧 Tasks
🏁 Checklist
docs/has been updated or is not required