Add user profile, allow to edit it, if server supports it by tobiasKaminsky · Pull Request #1092 · nextcloud/talk-android

tobiasKaminsky · 2021-03-29T12:27:07Z

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

mahibi · 2021-03-30T14:46:57Z

editing fields don't show up when clicking on "edit" if initially no field has any data

mahibi · 2021-03-30T14:49:39Z

enter edit mode
bring app to background / turn off display
open app again
--> editing mode is active but button says "EDIT" instead of "SAVE"

mahibi · 2021-03-30T15:00:23Z

when some fields are filled but others are left blank it looks pretty random where they are placed in the overview view.

mahibi · 2021-03-30T15:43:11Z

i see no avatar (also not the generated one with letters) and have no ability to set any

mahibi · 2021-03-31T12:14:48Z

please describe changes in the changelog.md

tobiasKaminsky · 2021-04-07T07:49:53Z

editing fields don't show up when clicking on "edit" if initially no field has any data

How did you managed to have this?
I cannot remove full name nor email, once it is set.

tobiasKaminsky · 2021-04-07T07:53:46Z

editing fields don't show up when clicking on "edit" if initially no field has any data

How did you managed to have this?
I cannot remove full name nor email, once it is set.

New user it is…

tobiasKaminsky · 2021-04-07T11:01:13Z

i see no avatar (also not the generated one with letters) and have no ability to set any

I guess that some server side PR is missing.

tobiasKaminsky · 2021-04-07T11:20:11Z

❗ rebased ❗

mahibi · 2021-04-07T11:59:14Z

22 new FindBugs warnings? @tobiasKaminsky

AndyScherzinger · 2021-04-07T22:10:43Z

❗ rebased ❗

plus added some improvements to the UI xml code

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

(avoid the word "phonebook" because then people would expect that numbers are used in the nc contact app) Signed-off-by: Marcel Hibbe <dev@mhibbe.de>

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

…th Files Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

AndyScherzinger · 2021-04-08T08:25:19Z

@tobiasKaminsky @mahibi latest commits optimize layouting (whitespaces and dark/light theming)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>

mahibi · 2021-04-08T13:41:41Z

/backport to v11.x

backportbot-nextcloud · 2021-04-08T13:41:51Z

The backport to v11.x failed. Please do this backport manually.

nextcloud-android-bot · 2021-04-08T14:07:01Z

Lint

Type	Master	PR
Warnings	130	130
Errors	3	3

FindBugs (new)

Warning Type	Number
Bad practice Warnings	12
Correctness Warnings	195
Experimental Warnings	2
Internationalization Warnings	8
Performance Warnings	62
Security Warnings	8
Dodgy code Warnings	246
Total	533

FindBugs (master)

Warning Type	Number
Bad practice Warnings	12
Correctness Warnings	279
Experimental Warnings	2
Internationalization Warnings	8
Performance Warnings	60
Security Warnings	17
Dodgy code Warnings	292
Total	670

Backport of #1092

tobiasKaminsky added the 3. to review Waiting for reviews label Mar 29, 2021

tobiasKaminsky requested a review from mahibi March 29, 2021 12:27

tobiasKaminsky force-pushed the profile branch from 6591b96 to 3a47d76 Compare March 29, 2021 13:17

AndyScherzinger reviewed Mar 30, 2021

View reviewed changes

Comment thread app/src/main/res/drawable/ic_password.xml Outdated

AndyScherzinger reviewed Mar 30, 2021

View reviewed changes

Comment thread app/src/main/res/drawable/upload.xml Outdated

mahibi reviewed Mar 30, 2021

View reviewed changes

Comment thread app/src/main/java/com/nextcloud/talk/controllers/ProfileController.java Outdated

tobiasKaminsky commented Apr 7, 2021

View reviewed changes

Comment thread app/src/main/res/values/strings.xml Outdated

tobiasKaminsky force-pushed the profile branch from 95b279e to 906c952 Compare April 7, 2021 11:20

tobiasKaminsky requested review from AndyScherzinger and mahibi April 7, 2021 11:20

tobiasKaminsky mentioned this pull request Apr 7, 2021

Change avatar on web, see inconsistent behaviour #1067

Closed

AndyScherzinger force-pushed the profile branch from 894e569 to 3f86c68 Compare April 7, 2021 22:09

tobiasKaminsky and others added 7 commits April 8, 2021 09:43

Add user profile, allow to edit it, if server supports it

4f0923b

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

Updated strings / icon to match server

e8a2857

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

modify descriptions for phone number integration

1fec3e7

(avoid the word "phonebook" because then people would expect that numbers are used in the nc contact app) Signed-off-by: Marcel Hibbe <dev@mhibbe.de>

Fix bugs found by Marcel

a57253e

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

Fixed some spotbugs, excluded some bug categories to be consistent wi…

6fb5d3f

…th Files Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

Clear cached avatar

4310866

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

move variable declaration up to fix compile issue

d497cdd

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

extracted shimmer element for user detail items

e224e09

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

tobiasKaminsky force-pushed the profile branch from 3f86c68 to e224e09 Compare April 8, 2021 07:43

AndyScherzinger added 4 commits April 8, 2021 09:48

respect light/dark theming

c461ddc

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

use proper logging API

b1a60b6

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

proper user info item text size

a6c05ca

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

optimize bottom sheet layout and make it dark/light theme aware

7de3b1e

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

remove unused resources

208e96e

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

AndyScherzinger approved these changes Apr 8, 2021

View reviewed changes

tobiasKaminsky and others added 3 commits April 8, 2021 14:15

Upon error on saving, revert value

ea50cf6

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

show only fieldname in toast when saving failed

9835093

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>

add profile information and privacy settings to changelog

4777e83

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>

mahibi approved these changes Apr 8, 2021

View reviewed changes

mahibi merged commit ab061d1 into master Apr 8, 2021

delete-merged-branch Bot deleted the profile branch April 8, 2021 13:15

backportbot-nextcloud Bot added the backport-request label Apr 8, 2021

mahibi added a commit that referenced this pull request Apr 8, 2021

Merge pull request #1112 from nextcloud/backport-profile

e42d53a

Backport of #1092

AndyScherzinger mentioned this pull request May 26, 2021

Error reading user fields for profile editing #1294

Closed

Uh oh!

Uh oh!

Conversation

tobiasKaminsky commented Mar 29, 2021

Uh oh!

Uh oh!

Uh oh!

mahibi commented Mar 30, 2021

Uh oh!

mahibi commented Mar 30, 2021

Uh oh!

mahibi commented Mar 30, 2021

Uh oh!

mahibi commented Mar 30, 2021

Uh oh!

Uh oh!

mahibi commented Mar 31, 2021

Uh oh!

Uh oh!

tobiasKaminsky commented Apr 7, 2021

Uh oh!

tobiasKaminsky commented Apr 7, 2021

Uh oh!

tobiasKaminsky commented Apr 7, 2021

Uh oh!

tobiasKaminsky commented Apr 7, 2021

Uh oh!

mahibi commented Apr 7, 2021

Uh oh!

AndyScherzinger commented Apr 7, 2021

Uh oh!

AndyScherzinger commented Apr 8, 2021

Uh oh!

mahibi commented Apr 8, 2021

Uh oh!

backportbot-nextcloud Bot commented Apr 8, 2021

Uh oh!

nextcloud-android-bot commented Apr 8, 2021

Lint

FindBugs (new)

FindBugs (master)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants