Performance/create session with content - #2225
Merged
Merged
Conversation
max-nextcloud
force-pushed
the
performance/create-session-with-content
branch
from
March 8, 2022 08:02
a24eefe to
632ac30
Compare
max-nextcloud
commented
Mar 8, 2022
max-nextcloud
force-pushed
the
performance/create-session-with-content
branch
from
March 8, 2022 12:39
632ac30 to
858d947
Compare
Simplify the session creation code a bit: * handle the two ways of initializing a sesson only in SyncService. * use async instead of .then(...) * handle errors in helper function. Signed-off-by: Max <max@nextcloud.com>
juliusknorr
force-pushed
the
performance/create-session-with-content
branch
from
March 8, 2022 21:59
858d947 to
1661fa3
Compare
juliusknorr
approved these changes
Mar 8, 2022
juliusknorr
left a comment
juliusknorr
left a comment
Member
There was a problem hiding this comment.
Nice, thanks for looking into that 👍
Collaborator
Author
|
/compile amend / |
Signed-off-by: Max <max@nextcloud.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
performance/create-session-with-content
branch
from
March 9, 2022 05:23
1661fa3 to
fd63951
Compare
delete-merged-branch
Bot
deleted the
performance/create-session-with-content
branch
March 9, 2022 05:37
39 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fetch the content of the file when creating the session. Saves the
fetchrequest whenever noinitialSessionis given. On my dev instance this saves 80ms - but it's hard to tell how much it will save in production. Well it will save one roundtrip that is currently blocking the rendering of the content.