Add APIs for outline state to RichTextReader and WrapperComponent - #3462
Merged
Conversation
|
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||||||||||||||||||||||
mejo-
force-pushed
the
enh/outline_npm
branch
from
November 21, 2022 18:04
2bf1b53 to
76c4614
Compare
max-nextcloud
left a comment
max-nextcloud
left a comment
Collaborator
There was a problem hiding this comment.
So far looks good to me. I guess the handing down props and propagating up events could be avoided by using provide and inject - but from what i see it's only two levels. So I'm not sure if that's worth it.
Export `OUTLINE_STATE` and `OUTLINE_ACTIONS` in NPM package. Also add `EditorOutline` to `BaseReader` dom structure, so it can be toggled by providing `OUTLINE_STATE` and `OUTLINE_ACTIONS` from a parent vue component. Signed-off-by: Jonas <jonas@freesources.org>
* Emit `outline-toggled` event when outline got toggled from Text * Allow to pass property `showOutlineOutside` for changing outline state from parent component. This is required to support toggeling the outline from inside Collectives. Related: #2919 Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
mejo-
force-pushed
the
enh/outline_npm
branch
from
November 22, 2022 11:49
76c4614 to
ac3518e
Compare
mejo-
marked this pull request as ready for review
November 22, 2022 11:49
Member
Author
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
max-nextcloud
self-requested a review
November 22, 2022 12:04
max-nextcloud
approved these changes
Nov 22, 2022
max-nextcloud
left a comment
max-nextcloud
left a comment
Collaborator
There was a problem hiding this comment.
Had a quick look at the code again.
Member
Author
|
/backport 2ed516d,a9f4db5ad7bae90d30e7960da68b02657165ff10,ac3518e4c5e7c064f5bd15489c32d3125b3b4fda to stable25 |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Adds APIs to interfere with outline state to
RichTextReaderandWrapperComponentcomponents.Required for https://gitlab.com/collectivecloud/collectives/-/merge_requests/649
🚧 TODO
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)