test(cy): rely on @nextcloud/axios for requests - #5727
Merged
Conversation
max-nextcloud
force-pushed
the
test/simplify-cypress-requests
branch
2 times, most recently
from
April 25, 2024 07:02
2902033 to
5db6712
Compare
This comment was marked as resolved.
This comment was marked as resolved.
max-nextcloud
force-pushed
the
test/simplify-cypress-requests
branch
3 times, most recently
from
April 26, 2024 05:52
4cc24c2 to
e1baf67
Compare
max-nextcloud
marked this pull request as draft
April 26, 2024 12:02
This comment was marked as resolved.
This comment was marked as resolved.
max-nextcloud
force-pushed
the
test/simplify-cypress-requests
branch
from
May 1, 2024 09:10
e1baf67 to
4d1a54c
Compare
This greatly simplifies the handling of csrf-tokens and auth. Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
max-nextcloud
force-pushed
the
test/simplify-cypress-requests
branch
from
May 2, 2024 04:31
4d1a54c to
62ecdf6
Compare
Extract function `enterContentAndClose()`. Signed-off-by: Max <max@nextcloud.com>
max-nextcloud
marked this pull request as ready for review
May 2, 2024 05:05
juliusknorr
approved these changes
May 2, 2024
Member
|
Very nice cleanup 🚀 |
Member
|
/backport to stable29 |
2 tasks
Member
|
/backport to stable28 |
2 tasks
Member
|
/backport to stable29 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify the handling of csrf-tokens and auth.
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)