fix: Reuse NcAutoCompleteResult, remove code duplication - #6192
Merged
Conversation
juliusknorr
force-pushed
the
jtr/fix/3142
branch
from
August 14, 2024 14:30
0a6114f to
276ca75
Compare
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
juliusknorr
force-pushed
the
jtr/fix/3142
branch
from
August 28, 2024 19:04
276ca75 to
bca8e93
Compare
Contributor
|
Looks good to me 👍 |
mejo-
approved these changes
Sep 4, 2024
mejo-
marked this pull request as ready for review
September 4, 2024 09:50
Member
|
Tested and works well. Thanks @joshtrichards ❤️ |
Member
|
/backport to stable30 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
🖼️ Screenshots
🚧 TODO
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)