[stable29] fix: preserve OCA.Text properties in public share script - #8158
Merged
Conversation
Prevent race condition where text-public.js would overwrite createEditor/createTable methods if text-editors.js loaded first. Uses spread operator to merge instead of replace, matching the pattern already used in editor.js. Signed-off-by: silver <s.szmajduch@posteo.de>
AndyScherzinger
approved these changes
Jan 15, 2026
juliusknorr
reviewed
Jan 15, 2026
Co-authored-by: Julius Knorr <jus@bitgrid.net> Signed-off-by: Sylwia <83009937+silverkszlo@users.noreply.github.com>
Member
|
@silverkszlo could you double check the CI results? |
silverkszlo
approved these changes
Jan 15, 2026
silverkszlo
left a comment
silverkszlo
left a comment
Collaborator
There was a problem hiding this comment.
The failing cypress tests are unrelated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #8156