fix(HardBreak): render DOM linebreak as soft breaks - #8798
Closed
mejo- wants to merge 1 commit into
Closed
Conversation
Fixes: #8775 prosemirror-model 1.25.4 now conversts newlines into the schema's linebreakReplacement (our HardBreak), producing spurious `<br>` in nested bullet lists as we use `preserveWhitspace: true` there.. The commit fixes this by distinguishing HardBreaks: when created as linebreakReplacement, they become type 'soft', otherwise the old behaviour is retained. The added tests are not regression tests for #8775. They ensure that multi-line list items are preserved in Markdown (which they would not with `preserveWhitespace: false` in BulletList). Signed-off-by: Jonas <jonas@freesources.org>
github-project-automation
Bot
moved this to 🧭 Planning evaluation (don't pick)
in 📝 Productivity team
Member
Author
|
#8856 is the cleaner and better solution. |
github-project-automation
Bot
moved this from 🧭 Planning evaluation (don't pick)
to ☑️ Done
in 📝 Productivity team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #8775
prosemirror-model 1.25.4 now conversts newlines into the schema's linebreakReplacement (our HardBreak), producing spurious
<br>in nested bullet lists as we usepreserveWhitspace: truethere..The commit fixes this by distinguishing HardBreaks: when created as linebreakReplacement, they become type 'soft', otherwise the old behaviour is retained.
The added tests are not regression tests for #8775. They ensure that multi-line list items are preserved in Markdown (which they would not with
preserveWhitespace: falsein BulletList).🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)🤖 AI (if applicable)