Fix group lookup failing on large GitLab instances#3
Merged
Conversation
The groups API query used per_page=10000, which GitLab silently caps at 100. On instances with more than 100 groups, the target namespace may not appear in results, causing group_id to stay None and project creation to fall back to the user's personal namespace. Fix: add search= parameter using the leaf component of the namespace so the API filters server-side, making pagination irrelevant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The groups API query used
per_page=10000, which GitLab silently caps at 100. On instances with more than 100 groups, the target namespace may not appear in results, causinggroup_idto stayNoneand project creation to fall back to the user's personal namespace, producing the error:Fix
Add a
search=parameter using the leaf component of the namespace (e.g.myaccidentfromMyAccident, orfindlaw-techfromfindlaw/findlaw-tech). This filters server-side so pagination is never an issue. The existingfull_pathcomparison then disambiguates if multiple groups share the same leaf name.